Skip to content

Commit

Permalink
drm/panic: remove unnecessary borrow in alignment_pattern
Browse files Browse the repository at this point in the history
The function `alignment_pattern` returns a static reference to a `u8`
slice. The borrow of the returned element in `ALIGNMENT_PATTERNS` is
already a reference as defined in the array definition above so this
borrow is unnecessary and removed by the compiler. Clippy notes this in
`needless_borrow`:

    error: this expression creates a reference which is immediately dereferenced by the compiler
       --> drivers/gpu/drm/drm_panic_qr.rs:245:9
        |
    245 |         &ALIGNMENT_PATTERNS[self.0 - 1]
        |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ALIGNMENT_PATTERNS[self.0 - 1]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
        = note: `-D clippy::needless-borrow` implied by `-D warnings`
        = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

Remove the unnecessary borrow.

Reported-by: Miguel Ojeda <[email protected]>
Closes: Rust-for-Linux#1123
Signed-off-by: Thomas Böhler <[email protected]>
  • Loading branch information
Witcher01 authored and intel-lab-lkp committed Oct 12, 2024
1 parent 7ba9a4c commit 2d131c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/drm_panic_qr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ impl Version {
}

fn alignment_pattern(&self) -> &'static [u8] {
&ALIGNMENT_PATTERNS[self.0 - 1]
ALIGNMENT_PATTERNS[self.0 - 1]
}

fn poly(&self) -> &'static [u8] {
Expand Down

0 comments on commit 2d131c3

Please sign in to comment.