Upgrade substrate to 7406442bea0194ffcafc4e8d48d895d4d8d11346 #540
Conversation
|
Please don't merge for now. |
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Looks good to me, only one minor comment, otherwise we can merge. Thanks for your hard work on this one!
| TEEREX, | ||
| "ProcessedParentchainBlock", | ||
| Some(decoder.clone()), | ||
| None, |
There was a problem hiding this comment.
Good point, this is obsolete in the api-client. I need to remove that arg.
| pub fn grandpa_log<Block: BlockT>( | ||
| digest: &DigestG<HashFor<Block>>, | ||
| ) -> Option<ConsensusLog<NumberFor<Block>>> { | ||
| pub fn grandpa_log<Block: BlockT>(digest: &DigestG) -> Option<ConsensusLog<NumberFor<Block>>> { |
There was a problem hiding this comment.
Please rename the import to just Digest. The G stands for generic, which is not the case anymore.
haerdib
left a comment
haerdib
left a comment
There was a problem hiding this comment.
LGTM. Few minor comments.
|
|
||
| pub fn pending_change<Block: BlockT>( | ||
| digest: &DigestG<HashFor<Block>>, | ||
| digest: &DigestG, |
There was a problem hiding this comment.
Same as clangenbs comment above: Remove G
Compile with error duplicate lang item in crate `sgx_tstd` Sgx runtime upgraded to new substrate, but has extrinsics-factory errors. Upgrade works, problem in substrate-api-client fixed in version #a4d931c85f30ba22ff1f982c47caf57fe43ebc90 Rebase to master and update changes to new substrate cargo clippy Remove patch to local dependencies Remove comments Update spec version to 4 Changes from review
echevrier
force-pushed
the
ec_upgrade_substrate_v14metadata
branch
from
4c2cbec to
820d72d
Compare
For compatibility reason, the node requiring V14 metadata integritee-network/integritee-node#83
merge upgraded node first upgrade substrate dep to > v14 metadata integritee-node#85 and update worker CI to use this node.
merge upgraded sgx-runtime Upgrade to substrate 7406442bea0194ffcafc4e8d48d895d4d8d11346 sgx-runtime#39