Specify 'untrusted_time' feature explicitely in crates with sgx_tstd #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renders the 'use std::untrusted::time*' imports obsolete. The reason we're doing this, is because in a feature branch we encountered clippy issues about these imports being unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders the
use std::untrusted::time::*imports obsolete.We do this because in a feature branch we encountered clippy issues about these imports being unused (in #442 ). It is still not entirely clear why these clippy warnings appear on that specific branch.
One suspicion is, that somehow a new/changed dependency now enables the
sgx_tstd/untrusted_timefeature which wasn't the case before.