Conversation
clangenb
commented
Jul 5, 2021
| Sgx(sgx_status_t) | ||
| } | ||
|
|
||
| impl From<Error> for sgx_status_t { |
Contributor
Author
There was a problem hiding this comment.
Implementing From gives you Into for free, which is what we actually need.
brenzi
approved these changes
Jul 5, 2021
Collaborator
brenzi
left a comment
brenzi
left a comment
There was a problem hiding this comment.
won't merge before other reviews are in
murerfel
reviewed
Jul 5, 2021
haerdib
reviewed
Jul 5, 2021
haerdib
reviewed
Jul 5, 2021
haerdib
approved these changes
Jul 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: First merge #280
Todo: