Api client extensions: SubstrateeRegistryApi + AcountApi + ChainApi #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Converted this to draft. I will also add |
clangenb
changed the title
…ities_proof to ChainApi
clangenb
force-pushed
the
api-client-extensions
branch
from
25e53f7 to
ca8c4fb
Compare
…ncing custom api-client error.
This was referenced Jun 23, 2021
Merged
Contributor
Author
|
ready to merge |
brenzi
approved these changes
Jun 29, 2021
Collaborator
brenzi
left a comment
brenzi
left a comment
There was a problem hiding this comment.
I'd like to see a unit test using this abstraction soon ;-) but won't block the PR because of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add api client extensions.
I introduced this now with the testing in mind while developing/testing the broadcasting of sidechain blocks.
Because: Having the node-api behind a trait allows introducing easily a
MockApithat returns hard-coded answers.Note: Merge #267 first.