polkadot-v0.9.32 #172
polkadot-v0.9.32 #172
Conversation
| } | ||
|
|
||
| impl frame_system::Config for Runtime { | ||
| /// The identifier used to distinguish between accounts. |
There was a problem hiding this comment.
Removed the bad documentation and re-order the definitions to be the same as the upstream statemine runtime.
| pub UnvestedFundsAllowedWithdrawReasons: WithdrawReasons = | ||
| WithdrawReasons::except(WithdrawReasons::TRANSFER | WithdrawReasons::RESERVE); |
There was a problem hiding this comment.
Todo: double-check this config. It is taken from integritee-network/integritee-node#159
| type MaxDeposits = ConstU32<100>; | ||
| type MaxBlacklisted = ConstU32<100>; |
There was a problem hiding this comment.
Taken from statemine.
| RandomnessCollectiveFlip: pallet_randomness_collective_flip::{Pallet, Storage} = 2, | ||
| Timestamp: pallet_timestamp::{Pallet, Call, Storage, Inherent} = 3, | ||
| ParachainInfo: parachain_info::{Pallet, Storage, Config} = 4, | ||
| Preimage: pallet_preimage = 5, |
There was a problem hiding this comment.
Todo: double check if we have never used index 5 to be sure that we don't have a storage hash collision.
| impl pallet_transaction_payment_rpc_runtime_api::TransactionPaymentCallApi<Block, Balance, RuntimeCall> | ||
| for Runtime | ||
| { | ||
| fn query_call_info( | ||
| call: RuntimeCall, | ||
| len: u32, | ||
| ) -> pallet_transaction_payment::RuntimeDispatchInfo<Balance> { | ||
| TransactionPayment::query_call_info(call, len) | ||
| } | ||
| fn query_call_fee_details( | ||
| call: RuntimeCall, | ||
| len: u32, | ||
| ) -> pallet_transaction_payment::FeeDetails<Balance> { | ||
| TransactionPayment::query_call_fee_details(call, len) | ||
| } | ||
| } |
There was a problem hiding this comment.
Todo: check why we never had this, it does not make sense for me.
| #[cfg(feature = "try-runtime")] | ||
| impl frame_try_runtime::TryRuntime<Block> for Runtime { |
There was a problem hiding this comment.
Useful testing feature to perform a runtime upgrade in cargo test. We should finally use this feature!
| // Standard Error: 0 | ||
| .saturating_add(Weight::from_ref_time(6_000).saturating_mul(z.into())) | ||
| .saturating_add(T::DbWeight::get().reads(2)) | ||
| .saturating_add(T::DbWeight::get().writes(1)) |
There was a problem hiding this comment.
All the weight files are copied and pasted from the kusama runtime. We need to run the benchmarks again before deployment.
| pub enum Subcommand { | ||
| /// Key management CLI utilities | ||
| #[clap(subcommand)] | ||
| #[command(subcommand)] |
There was a problem hiding this comment.
Due to clap dependency update
| pub const MaxInstructions: u32 = 100; | ||
| } | ||
|
|
||
| pub struct XcmConfig; |
There was a problem hiding this comment.
Remember we need to update the XCM config for the slot swap as the current settings do not allow the shell runtime to send xcm messages: #160
|
Closing in favor of #176 |
Todo:
Subwasm fails to load the metadata. Reasons unknown. Updating subwasm to 0.18.0 did not help. See this discussion for more information: integritee-network/integritee-node#159 (comment)