fix: Add missed parameter to the github_organization_ruleset

[yurii-kysil]

Resolves #2542

---

Before the change?

• No parameter in github_organization_ruleset that cause an error, as it's required in respository_rules_utils.expandRules

After the change?

• The parameter is added to the github_organization_ruleset with the default value

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[psalaberria002]

It would be nice to have this merged. Can someone review it?

[awendt]

@kfcampbell Can we please get this fix merged and released?

[adan-babbel]

Hi @kfcampbell can you please review and merge this?

[grimm26]

@yurii-kysel Should probably also update https://github.com/integrations/terraform-provider-github/blob/main/website/docs/r/organization_ruleset.html.markdown in this PR, too

[CpuID]

fairly sure this PR fixes #2597 - would be great to have it approved/merged :)

[CpuID]

oh and #2542 would get closed out too (already linked)

[dcreey]

We actually also need it on the required_workflows struct too

terraform-provider-github/github/resource_github_organization_ruleset.go

Line 430 in eb3c14c

"required_workflows": {

[anGie44]

based on the error you could prevent future panics in

terraform-provider-github/github/respository_rules_utils.go

Lines 343 to 348 in 9fceeda

	doNotEnforceOnCreate := requiredStatusMap["do_not_enforce_on_create"].(bool)
	params := &github.RequiredStatusChecksRuleParameters{
	RequiredStatusChecks: requiredStatusChecks,
	StrictRequiredStatusChecksPolicy: requiredStatusMap["strict_required_status_checks_policy"].(bool),
	DoNotEnforceOnCreate: &doNotEnforceOnCreate,
	}

as well by doing something like

		params := &github.RequiredStatusChecksRuleParameters{
			RequiredStatusChecks:             requiredStatusChecks,
		}

		if v, ok := requiredStatusMap["do_not_enforce_on_create"].(bool); ok {
			params.DoNotEnforceOnCreate =  &v
                }

                if v, ok := requiredStatusMap["strict_required_status_checks_policy"].(bool); ok {
                       params.StrictRequiredStatusChecksPolicy = v
                }

[anGie44]

(but the Default: false should prevent that from happening 😅 )

[yklebanov]

What's the status on this?

[grimm26]

None of that matters unless M$ Github actually allocates time for their people to merge PRs. Plenty of us are actual paying GHE customers and are being ignored.