[BUG]: 5.43 upgrade failing due to signoff issues

[mattklein123]

Expected Behavior

Just got the 5.43 upgrade and I'm seeing failures like:

Error: PATCH https://api.github.com/repos/***: 422 Commit signoff is enforced by the organization and cannot be disabled []

I assume this is somehow due to https://github.com/integrations/terraform-provider-github/pull/2007/files. I've tried manually adding web_commit_signoff_required but this still seems to fail:

 # module.***.github_repository.repo will be updated in-place
  ~ resource "github_repository" "repo" {
      + web_commit_signoff_required = true
        # (35 unchanged attributes hidden)
    }

Is this related to something else or is there something else I should be doing here? Thank you.

Actual Behavior

Doesn't fail / backwards compatible.

Terraform Version

1.2.6, 5.43

Affected Resource(s)

• github_repository (I think)

Terraform Configuration Files

No response

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[nnellanspdl]

I know it's not a fix, but ignoring that field might be a workaround for now?

resource "github_repository" "repo" {
  lifecycle {
    ignore_changes = [
      web_commit_signoff_required
    ]
  }
}

[nyanhp]

I know it's not a fix, but ignoring that field might be a workaround for now?

resource "github_repository" "repo" {
  lifecycle {
    ignore_changes = [
      web_commit_signoff_required
    ]
  }
}

Unfortunately, this does not seem to help either. The error also occurs on a completely new deployment, as soon as the repository resource is applied.

[brunooon]

I know it's not a fix, but ignoring that field might be a workaround for now?

resource "github_repository" "repo" {
  lifecycle {
    ignore_changes = [
      web_commit_signoff_required
    ]
  }
}

Unfortunately, this does not seem to help either. The error also occurs on a completely new deployment, as soon as the repository resource is applied.

I was still facing the same issue, so I had to remove the commit signoff from the org and I'm setting to true only on the repos now, its working so far.

[mrclrchtr]

Same here... 😕 with version 6.0.0
Only for initial creation I think.

[mvarchdev]

Same here, using pulumi/github