Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC: Added Snippet saving feature #118

Merged
merged 2 commits into from
Feb 21, 2025
Merged

PC: Added Snippet saving feature #118

merged 2 commits into from
Feb 21, 2025

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Feb 14, 2025

Closes #116
Connecting Editor: intechstudio/grid-editor#975

Added ability to save snippets similiar to presets/profiles.

NOTE: To use the PC bould, a compatible editor is needed. (See above).
IMPORTANT: Online builds of editor does not support snippet/preset/profile save.

Usage

  1. Select action blocks in action list
  2. Click on + sing in profile cloud, and follow the procedure similiar to preset/profile save
  3. To Load snippets on an event, drag and drop the snippet in Profile Cloud to destination similiar to regular action block drag and drop.

When no action blocks are selected, the snippet saving procedure can be done, but an error message prompts the user about the failed snippet saving (similiar to profile/preset save when no device is connected)

Copy link

github-actions bot commented Feb 14, 2025

Visit the preview URL for this PR (updated for commit bf7f168):

https://profile-cloud-dev--pr118-feat-snippets-v9sna8wo.web.app

(expires Tue, 25 Feb 2025 16:12:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2a004f867edf1347070dd9beedb18755187a6d4e

@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Feb 17, 2025

  • Dropzone should be visible when adding to empty event, or inbetween composite blocks

@Greg-Orca
Copy link

Test Failed

  • Load Snippet with an empty field causes [object Object] error
    Repro: Save a MIDI block with an empty field, then load it back to the element.

  • Load Snippet to an element that exceeds the script length causes [object Object] error
    Expected: Display a footer message instead.

  • NRPN 14-bit Resolution checkbox state is not saved when enabled

@elsoazemelet
Copy link
Contributor Author

Test Failed

  • Load Snippet with an empty field causes [object Object] error
    Repro: Save a MIDI block with an empty field, then load it back to the element.
  • Load Snippet to an element that exceeds the script length causes [object Object] error
    Expected: Display a footer message instead.
  • NRPN 14-bit Resolution checkbox state is not saved when enabled
  1. Issue can not be reproduced
  2. Fixed
  3. Independed issue (is present on stable), created draft

@Greg-Orca
Copy link

Test Passed

@elsoazemelet elsoazemelet merged commit 7e9b530 into main Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PC: Save/Load selected actionblocks as config (snippet)
2 participants