Fixed bug where pyarrow conversions were causing string accessor to fail in search#718
Merged
charles-turner-1 merged 1 commit intomainfrom May 8, 2025
Merged
Fixed bug where pyarrow conversions were causing string accessor to fail in search#718charles-turner-1 merged 1 commit intomainfrom
charles-turner-1 merged 1 commit intomainfrom
Conversation
charles-turner-1
added a commit
that referenced
this pull request
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
try/exceptfor a case where pyarrow conversions (polars <=> pandas stuff) were causing the search functionality to fail on columns with iterables.Not exactly sure why this only happens with this specific case, nor why other tests didn't catch but given I'm planning on rewriting the search functionality using polars soon anyway (#711) I'm not too worried. I'm guessing probably something to do with the compression since none of test catalogues relating to
columns_with_iterablesare gzipped.No apparent other related issues I can find.
Related issue number
N/A
Checklist