Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error output #174

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Improve error output #174

merged 1 commit into from
Aug 31, 2019

Conversation

garethr
Copy link
Collaborator

@garethr garethr commented Aug 19, 2019

Current output:

The file fixtures/multi_invalid.yaml contains a valid ReplicationController
The file fixtures/multi_invalid.yaml contains a valid Service
The file fixtures/multi_invalid.yaml contains a valid ReplicationController
The file fixtures/multi_invalid.yaml contains a valid Service
The file fixtures/multi_invalid.yaml contains a valid ReplicationController
5 errors occurred:
        * Missing 'kind' value
        * Missing 'kind' value
        * Missing 'kind' value
        * Missing 'kind' value
        * Missing 'kind' value

With the changes

The file fixtures/multi_invalid.yaml contains a valid ReplicationController
The file fixtures/multi_invalid.yaml contains a valid Service
The file fixtures/multi_invalid.yaml contains a valid ReplicationController
The file fixtures/multi_invalid.yaml contains a valid Service
The file fixtures/multi_invalid.yaml contains a valid ReplicationController
Error with fixtures/multi_invalid_resources.yaml: Missing 'kind' value
Error with fixtures/multi_invalid_resources.yaml: Missing 'kind' value
Error with fixtures/multi_invalid_resources.yaml: Missing 'kind' value
Error with fixtures/multi_invalid_resources.yaml: Missing 'kind' value
Error with fixtures/multi_invalid_resources.yaml: Missing 'kind' value

@garethr
Place error messages on a single line and include filename
2175d57 
Error messages at the moment don't carry context, which makes finding
errors when testing multiple files hard. Error messages also
take up lots of space currently. This commit resolves those issues.
@garethr garethr marked this pull request as ready for review August 31, 2019 06:44
@garethr garethr merged commit ff3f46a into master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garethr