Skip to content

Commit

Permalink
Remove extra caching as currently causing a segfault at runtime
Browse files Browse the repository at this point in the history
  • Loading branch information
garethr committed Aug 31, 2019
1 parent f142bb9 commit 092e382
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion kubeval/kubeval.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,9 @@ func downloadSchema(resource *ValidationResult, schemaCache map[string]*gojsonsc
errors.ErrorFormat = singleLineErrorFormat
}

// TODO: this currently triggers a segfault in offline cases
// We couldn't find a schema for this resource. Cache it's lack of existence, then stop
schemaCache[resource.VersionKind()] = nil
//schemaCache[resource.VersionKind()] = nil
return nil, errors.ErrorOrNil()
}

Expand Down

0 comments on commit 092e382

Please sign in to comment.