Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(many): hide required asterisks from screenreaders #1803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(many): hide required asterisks from screenreaders #1803

wants to merge 1 commit into from
+44 −8

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Nov 29, 2024

INSTUI-4374

also fixed 2 instances where the wrong color token was used

test plan:

  • check if screen readers ignore the required asterisk in field labels

@balzss balzss self-assigned this Nov 29, 2024
@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1803/
on branch gh-pages at 2024-11-29 14:56 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf approved these changes

@HerrTopi HerrTopi Awaiting requested review from HerrTopi

At least 2 approving reviews are required to merge this pull request.

Assignees

@balzss balzss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balzss @matyasf