Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ui-options): function based examples are added to Options #1649

Merged
merged 1 commit into from
Aug 30, 2024
Merged

docs(ui-options): function based examples are added to Options #1649

merged 1 commit into from
Aug 30, 2024

Conversation

Kadirsaglm
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Kadirsaglm Kadirsaglm force-pushed the write_functional_examples_for_options branch from 4e6ce5c to ff08671 Compare August 25, 2024 11:22
@matyasf matyasf self-assigned this Aug 26, 2024
@matyasf matyasf requested review from ToMESSKa and matyasf August 26, 2024 09:03
matyasf
matyasf approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, thanks for the contribution!

@Kadirsaglm
Copy link
Contributor Author

Is there anything needs to be done on my side about the failure of deploy preview?

@matyasf
Copy link
Collaborator

matyasf commented Aug 29, 2024

Is there anything needs to be done on my side about the failure of deploy preview?

Nope, its failing because of security restrictions, this is normal

@Kadirsaglm
Copy link
Contributor Author

Is there anything needs to be done on my side about the failure of deploy preview?

Nope, its failing because of security restrictions, this is normal

Are you planning to merge this PR? I can't merge because of the failing check

@matyasf matyasf merged commit 896954c into instructure:master Aug 30, 2024
10 of 11 checks passed
@matyasf
Copy link
Collaborator

matyasf commented Aug 30, 2024

Are you planning to merge this PR? I can't merge because of the failing check

Only repo maintainers are able to merge pull requests. When its approved by us we will merge it

@Kadirsaglm
Copy link
Contributor Author

Are you planning to merge this PR? I can't merge because of the failing check

Only repo maintainers are able to merge pull requests. When its approved by us we will merge it

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf approved these changes

@ToMESSKa ToMESSKa ToMESSKa approved these changes

Assignees

@matyasf matyasf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kadirsaglm @CLAassistant @matyasf @ToMESSKa @kadirsaglm41