fix: <Select/> width prop only applies to the input inside #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1248--preview-instui.netlify.app |
balzss
changed the title
matyasf
requested changes
Aug 9, 2023
Comment on lines
677
to
681
| const extendedStyle = { | ||
| ...(styles?.select as object), | ||
| width: this.props.width || '100%', | ||
| display: 'inline-block' | ||
| } |
There was a problem hiding this comment.
CSS should be in styles.ts. This should be in the select object there.
There was a problem hiding this comment.
good point, moved it there
matyasf
approved these changes
Aug 10, 2023
matyasf
reviewed
Aug 10, 2023
matyasf
approved these changes
Aug 16, 2023
joyenjoyer
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-3820
test plan:
width="8rem"to aSelectorSimpleSelectcomponent