Skip to content

feat(ray): add high scale config #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

feat(ray): add high scale config #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instill/helpers/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,3 +143,4 @@ class ImageToImageInput:
ENV_NUM_OF_MIN_REPLICAS = "RAY_NUM_OF_MIN_REPLICAS"
ENV_NUM_OF_MAX_REPLICAS = "RAY_NUM_OF_MAX_REPLICAS"
ENV_IS_TEST_MODEL = "RAY_IS_TEST_MODEL"
ENV_IS_HIGH_SCALE_MODEL = "RAY_IS_HIGH_SCALE_MODEL"
9 changes: 9 additions & 0 deletions instill/helpers/ray_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
DEFAULT_MAX_ONGOING_REQUESTS,
DEFAULT_MAX_QUEUED_REQUESTS,
DEFAULT_RAY_ACTOR_OPTIONS,
ENV_IS_HIGH_SCALE_MODEL,
ENV_IS_TEST_MODEL,
ENV_MEMORY,
ENV_NUM_OF_CPUS,
Expand Down Expand Up @@ -42,6 +43,11 @@ def __init__(self, deployable: Deployment) -> None:
self._update_num_cpus(float(0.001))
self._update_downscale_delay(60)

is_high_scale_model = os.getenv(ENV_IS_HIGH_SCALE_MODEL)
if is_high_scale_model is not None and is_high_scale_model.lower() == "true":
self._update_upscale_delay(120)
self._update_downscale_delay(600)

memory = os.getenv(ENV_MEMORY)
if memory is not None and memory != "":
self._update_memory(float(memory))
Expand Down Expand Up @@ -181,6 +187,9 @@ def _update_max_replicas(self, num_replicas: int):

return self

def _update_upscale_delay(self, upscale_delay_s: int):
self._autoscaling_config["upscale_delay_s"] = upscale_delay_s

def _update_downscale_delay(self, downscale_delay_s: int):
self._autoscaling_config["downscale_delay_s"] = downscale_delay_s

Expand Down