Respect survey schedules before sending SMS #2380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2283
The fix involves adding
not_before
andnot_after
fields toChannelBroker.ask
(aka,sms
, btw why don't we rename this??), and honoring them (it was only sent withChannelBroker.setup
(aka, 'ivr', ditto).The way to honor those fields involves:
nil
for SMS)ChannelBroker
dequeuesPending work:
Updated wiki:
https://github.com/instedd/surveda/wiki/Chart:-Start-Survey-(with-Channel-Broker)/565d79ddc3ac0b23f322a6584eac6604b533793e