Issue #86 set stopsignal in haproxy-keepalived image #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Define the
STOPSIGNALin haproxy-keepalived image.Why is this change being made?
Kubernetes must be told explicitly what signal to use; by default the stopsignal is
SIGUSR1and it should beSIGTERM.How was this tested? How can the reviewer verify your testing?
Local test: built image, launched under helm, then
helm delete haproxy-keepalived. Can now see the log messageReceived SIGTERMprior to container shutdown. (Still not working fully, though - the VIP isn't getting torn down despite the script apparently reaching the correct function.)Completion checklist