Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #119 - fix NAME parameter in nut-upsd #122

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

instantlinux
Copy link
Owner

Summary of Changes

Fix the default healthcheck for nut-upsd image.

Why is this change being made?

To address bug report from @Alarez777:

The healthcheck does not work in the nut-upsd container when the NAME environment variable is changed. It seems that the problem is in docker-tools/images/nut-upsd/dockerfile in this line because the $NAME variable is not considered:

HEALTHCHECK CMD upsc ups@localhost:3493 2>&1|grep -q stale && exit 1 || true

How was this tested? How can the reviewer verify your testing?

Local test: built image, launched with $NAME unset, then with $NAME set to a non-default value.

Completion checklist

  • The pull request is linked to all related issues
  • This change has unit test coverage
  • Documentation has been updated
  • Dependencies have been updated and verified

@instantlinux instantlinux merged commit e971c64 into main Aug 21, 2023
1 check passed
@instantlinux instantlinux deleted the ISS-119_ups branch August 21, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant