-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:on-delete :cascade #698
:on-delete :cascade #698
Conversation
tonsky
commented
Jan 9, 2025
•
edited
Loading
edited
- Optimize current on-delete impl
- Transform it into single recursive query
- Add delete-entity support to client datalog
- Add option to the explorer
- Add option to CLI schema file
3a084cd
to
193d5af
Compare
View Vercel preview at instant-www-js-optimize-cascade-delete-jsv.vercel.app. |
Progress so far:
|
b9f9191
to
0d35b0c
Compare
0d35b0c
to
293ab5b
Compare
db7d1ee
to
e2b34a9
Compare
To the best of my abilities, I made cascade expansion as a single query but it still sometimes triggers slow path. One of the culprits, I think, is I left a TODO, maybe plan it as a separate task? |
b31a931
to
2d52ce2
Compare
Okay I think store.js support for cascade is in, + tests |
4a11b67
to
61feb5a
Compare
915fb98
to
6705df1
Compare
6705df1
to
4a3ff22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool!