-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added early node 18 support #529
Conversation
cimg/node:18.0 now available 👍 |
|
There are a couple of dependencies, which do not install with Node 18: We need to install them as optional and skip the tests on Node 18 for now and wait for releases. We want to install them as optional dev dependency. |
127b356
to
c840757
Compare
89754ea
to
78a311d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
- we don't want to manually update the engine everytime there is a minor version - cimg/node:16 does not work
[ci skip]
Co-authored-by: Bastian Krol <[email protected]>
Co-authored-by: Bastian Krol <[email protected]>
Co-authored-by: Bastian Krol <[email protected]>
refs 96909 - we keep Node v18 build in Github settings as optional for now
- not needed anymore - was only added to install grpc - see #529
- not needed anymore - was only added to install grpc - see #529
- not needed anymore - was only added to install grpc - see #529
- not needed anymore - was only added to install grpc - see #529
- not needed anymore - was only added to install grpc - see #529
- not needed anymore - was only added to install grpc - see #529
Problems:
npm audit
is failing right now.Decisions:
Tasks