New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolved logging objects being undefined or missing #1509

Merged

kirrg001 merged 5 commits into main from fix-log-object-structure

Jan 13, 2025

Contributor

abhilash-sivan commented Jan 13, 2025 •

edited

Loading

refs INSTA-12533
some log messages did not log the corresponding objects

note:
In some places, I have used %s, and %o notations.
In some places where JSON.stringify is already used, I followed the same to keep the logs clean and more readable.

abhilash-sivan marked this pull request as ready for review

January 13, 2025 13:49

abhilash-sivan requested a review from a team as a code owner

January 13, 2025 13:49

Contributor

kirrg001 commented Jan 13, 2025

fix: log object structure made compatible with major loggers #1509

Suggestion

fix: resolved logging objects being undefined or missing

refs xxx

some log messages did not log the corresponding objects

abhilash-sivan changed the title ~~fix: log object structure made compatible with major loggers~~ fix: resolved logging objects being undefined or missing

kirrg001 reviewed

View reviewed changes

packages/aws-fargate/src/activate.js Outdated Show resolved Hide resolved

kirrg001 reviewed

View reviewed changes

packages/aws-lambda/src/metrics/npmPackageDescription.js Outdated Show resolved Hide resolved


          fix: resolved logging objects being undefined or missing

fe99ffb

 - refs INSTA-12533
 - some log messages did not log the corresponding objects

abhilash-sivan force-pushed the fix-log-object-structure branch from 63cebfa to fe99ffb Compare

January 13, 2025 14:41


          fix: extended updated syntax to more error logs

fb1d878

kirrg001 reviewed

View reviewed changes

packages/collector/src/announceCycle/unannounced.js Outdated Show resolved Hide resolved

kirrg001 reviewed

View reviewed changes

packages/core/src/tracing/cls.js Outdated Show resolved Hide resolved

kirrg001 reviewed

View reviewed changes

packages/core/src/tracing/cls.js Outdated Show resolved Hide resolved

kirrg001 reviewed

View reviewed changes

packages/google-cloud-run/src/activate.js Outdated Show resolved Hide resolved

abhilash-sivan and others added 3 commits

January 13, 2025 20:49


          chore: update packages/core/src/tracing/cls.js

2aa2392

Co-authored-by: kirrg001 <[email protected]>


          chore: update packages/core/src/tracing/cls.js

6f0e1e2

Co-authored-by: kirrg001 <[email protected]>


          chore: resolve pr comments

8b71316

kirrg001 approved these changes

View reviewed changes

Contributor

kirrg001 left a comment

LGTM

We should probably use error?.stack & error?.message everywhere as an extra protection. If we name all errors error or err, we can more easily refactor things.

kirrg001 merged commit 7715fed into main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet