fix(shared-metrics): removed fs-extra dependency from production #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
replace-fs-extra
branch
3 times, most recently
from
c2dc0e6 to
dcd6beb
Compare
aryamohanan
changed the title
aryamohanan
force-pushed
the
replace-fs-extra
branch
2 times, most recently
from
01e8f54 to
59ccf7d
Compare
aryamohanan
force-pushed
the
replace-fs-extra
branch
from
59ccf7d to
dec3388
Compare
kirrg001
reviewed
Oct 7, 2024
kirrg001
reviewed
Oct 7, 2024
kirrg001
approved these changes
Oct 7, 2024
aryamohanan
commented
Oct 7, 2024
| @@ -882,10 +877,10 @@ mochaSuiteFn('tracing/db2', function () { | |||
| .then(() => | |||
| testUtils.retry(() => | |||
| verifySpans(agentControls, controls, { | |||
| numberOfSpans: 14, | |||
| numberOfSpans: 15, | |||
There was a problem hiding this comment.
I noticed there are now 15 spans, likely because I’m using the native fs, which may have caused the span count to increase. If the test continues to fail again, so I will investigate further.
aryamohanan
force-pushed
the
replace-fs-extra
branch
from
8e99db6 to
f1a3d4e
Compare
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
aryamohanan
added a commit
that referenced
this pull request
Oct 18, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
aryamohanan
added a commit
that referenced
this pull request
Oct 21, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
aryamohanan
added a commit
that referenced
this pull request
Oct 22, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
aryamohanan
added a commit
that referenced
this pull request
Oct 23, 2024
- Native `fs.promises.cp` available in Node.js 18+. - See: https://nodejs.org/api/fs.html#fspromisescpsrc-dest-options - refs INSTA-786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external dependency
fs-extrahas been removed from the production dependencies. Previously, we couldn't use the nativefs.cpmodule due to its unavailability in earlier versions of Node.js 16. Now that we're deprecating support for versions below 18, we're switching to the native fs module See https://nodejs.org/api/fs.html#fspromisescpsrc-dest-optionsrefs #1265