-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dropped support for x-instana-service header #1355
Conversation
49f21b0
to
9dcffab
Compare
9dcffab
to
1b52cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Note: The X-Instana-Service HTTP header is not automatically collected. For it to work, the Instana agent must be configured , see "Capturing custom HTTP headers".
FYI Docs links are broken.
This is the correct link:
https://www.ibm.com/docs/en/instana-observability/current?topic=cha-configuring-host-agents-by-using-agent-configuration-file#capturing-custom-http-headers
We will fix it soon!
Suggestion for commit body:
|
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
BREAKING CHANGE: - Migration: Please configure the Instana agent to capture the X-Instana-Service header in the agent's configuration file. - For details, see: https://www.ibm.com/docs/en/instana-observability/current?topic=applications-services#specify-the-x-instana-service-http-header.
The capture of the
X-Instana-Service
header value asspan.data.service
has been removed from the tracer. According to the public documentation here:By default, Instana does not capture HTTP headers during tracing. However, you can configure HTTP header capture by modifying the agent's configuration file (/etc/instana/configuration.yaml) as follows:
The backend extracting the service name from the captured header.
Therefore, implementing this directly within our tracer by inspecting the
X-Instana-Service
header and adding the annotation is redundant. For this reason, the Instana tracer community has chosen not to capture the X-Instana-Service header within the tracer.