Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dropped support for node v14 and v16 #1348

Merged
merged 13 commits into from
Oct 7, 2024
Merged

fix: dropped support for node v14 and v16 #1348

merged 13 commits into from
Oct 7, 2024

Conversation

aryamohanan
Copy link
Contributor

@aryamohanan aryamohanan commented Sep 30, 2024 •
edited
Loading

Dropped support for Node.js versions 14 and 16, as they have already reached their end of life, see https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases

Todo

  • Update codebase to remove all prebuilds
  • Update code base to remove < v18 cases
  • Merge against v4 branch as breaking change.

refs INSTA-786

@aryamohanan aryamohanan force-pushed the drop-node-14-16 branch 2 times, most recently from 73b8a94 to d2b8b0b Compare October 1, 2024 04:51
@aryamohanan aryamohanan changed the base branch from main to v4 October 1, 2024 04:53
@aryamohanan aryamohanan force-pushed the drop-node-14-16 branch 2 times, most recently from e537fde to b4d4ddf Compare October 1, 2024 04:57
@aryamohanan aryamohanan changed the base branch from v4 to main October 1, 2024 05:19
@aryamohanan aryamohanan force-pushed the drop-node-14-16 branch 3 times, most recently from 79626de to a6e1b51 Compare October 1, 2024 05:27
@aryamohanan aryamohanan changed the base branch from main to v4 October 1, 2024 05:28
@aryamohanan aryamohanan force-pushed the drop-node-14-16 branch 2 times, most recently from d7a58be to 7a4cbf7 Compare October 1, 2024 07:19
@aryamohanan aryamohanan removed the WIP label Oct 1, 2024
@aryamohanan aryamohanan marked this pull request as ready for review October 1, 2024 10:08
@aryamohanan aryamohanan requested a review from a team as a code owner October 1, 2024 10:08
@aryamohanan aryamohanan changed the title fix: dropped support for node 14/16 fix: dropped support for node v14 and v16 Oct 1, 2024
kirrg001
kirrg001 reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some first comments.

.github/ISSUE_TEMPLATE/bug.yaml Show resolved Hide resolved
dockerfile-examples/Dockerfile.node-22.9.0 Outdated
@@ -1,8 +1,8 @@
# Bare Node.js 16 image.
# Bare Node.js 22 image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Filename dockerfile-examples/Dockerfile.node-v22

dockerfile-examples/Dockerfile.node-22.9.0-alpine-3.20 Outdated Show resolved Hide resolved
dockerfile-examples/Dockerfile.node-22.9.0-alpine-3.20-with-native Outdated Show resolved Hide resolved
dockerfile-examples/Dockerfile.node-22.9.0-yarn Outdated Show resolved Hide resolved
dockerfile-examples/node-22.9.0-yarn.sh Outdated Show resolved Hide resolved
native-dep-packs/rebuild-precompiled-addons.sh Outdated Show resolved Hide resolved
abhilash-sivan
abhilash-sivan previously approved these changes Oct 1, 2024
View reviewed changes
@abhilash-sivan abhilash-sivan self-requested a review October 1, 2024 14:58
@abhilash-sivan abhilash-sivan dismissed their stale review October 1, 2024 14:59

waiting for test runs and pending pr comments

kirrg001
kirrg001 reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we had a file:

Binary file removedBIN -94.7 KB
packages/shared-metrics/addons/darwin/x64/88/event-loop-stats.tar.gz

dockerfile-examples/node-v22-alpine.sh Show resolved Hide resolved
packages/aws-lambda-auto-wrap/esm/index.js Outdated Show resolved Hide resolved
packages/aws-lambda-auto-wrap/test/esm_test.js Outdated Show resolved Hide resolved
packages/collector/test/tracing/cloud/aws-sdk/v3/dynamodb/util.js Outdated Show resolved Hide resolved
packages/collector/test/tracing/cloud/aws-sdk/v3/s3/util.js Outdated Show resolved Hide resolved
packages/core/src/tracing/opentelemetry-instrumentations/wrap.js Outdated Show resolved Hide resolved
packages/core/src/tracing/clsHooked/index.js Outdated Show resolved Hide resolved
packages/core/src/util/esm.js Outdated Show resolved Hide resolved
packages/core/src/util/nodeJsVersionCheck.js Show resolved Hide resolved
packages/serverless/ci/dind-nodejs-aws-jq/Dockerfile Outdated Show resolved Hide resolved
@aryamohanan
Copy link
Contributor Author

Why did we had a file:

Binary file removedBIN -94.7 KB
packages/shared-metrics/addons/darwin/x64/88/event-loop-stats.tar.gz

That is for v17, not sure who added that.

@aryamohanan aryamohanan requested a review from kirrg001 October 7, 2024 04:32
kirrg001
kirrg001 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@kirrg001 kirrg001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work!

v14 leftovers I have found:

v16 leftovers:

  • packages/aws-lambda-auto-wrap/esm/utils.js
  • packages/aws-lambda-auto-wrap/src/utils.js

@aryamohanan aryamohanan merged commit 4dd8c5f into v4 Oct 7, 2024
1 check passed
@aryamohanan aryamohanan deleted the drop-node-14-16 branch October 7, 2024 14:17
@aryamohanan aryamohanan mentioned this pull request Oct 10, 2024
Merged
20 tasks
aryamohanan added a commit that referenced this pull request Oct 14, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
52f7d06 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 14, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
7ed8865 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 14, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
11dd952 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 14, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
e5c2b48 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 14, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
cd033b1 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 18, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
afe09bf 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 21, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
654d7b4 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 22, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
6cdbde1 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
aryamohanan added a commit that referenced this pull request Oct 23, 2024
@aryamohanan
fix: dropped support for node v14 and v16 (#1348)
aaa9ad4 
BREAKING CHANGE:
- Dropped support for Node.js versions 14 and 16.
- Reason: These versions have reached their end of life.
- More info: https://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhilash-sivan abhilash-sivan abhilash-sivan left review comments

@kirrg001 kirrg001 kirrg001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryamohanan @kirrg001 @abhilash-sivan