feat: added support for ioredis cluster #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
commented
Aug 28, 2024
kirrg001
commented
Aug 28, 2024
kirrg001
commented
Aug 28, 2024
kirrg001
commented
Aug 28, 2024
abhilash-sivan
approved these changes
Aug 29, 2024
aryamohanan
reviewed
Sep 4, 2024
| // node bin/start-test-containers.js --redis-node-0 --redis-node-1 --redis-node-2 | ||
| // docker exec -it 2aaaac7b9112 redis-cli -p 6379 cluster info | ||
| module.exports = async function connect(ioredis, log) { | ||
| if (!process.env.AZURE_REDIS_CLUSTER || !process.env.AZURE_REDIS_CLUSTER_PWD) { |
There was a problem hiding this comment.
While running the tests locally, I initially encountered the following issue:
[ioredis] Unhandled error event: ClusterAllFailedError: Failed to refresh slots cache.
The issue seems to have resolved itself after some time. It might be related to the cluster since we use the same cluster for both Redis and ioredis testing. Running tests in parallel could potentially cause conflicts. We should consider alternative solutions, such as using namespaces, to prevent this issue in the future.
There was a problem hiding this comment.
suggestion: We can create a card for now and do it later.
There was a problem hiding this comment.
kirrg001
force-pushed
the
ioredis-cluster
branch
from
c592030 to
e2cce47
Compare
kirrg001
added a commit
that referenced
this pull request
Sep 12, 2024
refs #1327 refs #1292 We thought that this is a bug. The tests were not really clear. We revert the multi/pipeline handling for now. Raised https://jsw.ibm.com/browse/INSTA-14540 for further investigation.
kirrg001
added a commit
that referenced
this pull request
Sep 12, 2024
refs #1327 refs #1292 We thought that this is a bug. The tests were not really clear. We revert the multi/pipeline handling for now. Raised https://jsw.ibm.com/browse/INSTA-14540 for further investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-9475