Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated q #1282

Merged
merged 3 commits into from
Aug 22, 2024
Merged

fix: deprecated q #1282

merged 3 commits into from
Aug 22, 2024

Conversation

aryamohanan
Copy link
Contributor

The Q library has been officially deprecated. The maintainers announced this deprecation in the project's GitHub repository, advising developers to transition to native JavaScript promises. The Q library, an early tool for handling promises in JavaScript, is no longer needed because modern JavaScript now includes built-in support for promises.

Please consider using JavaScript promises instead of Q. Native promises are faster, offer better tooling support, and represent the future.

— Comment from the maintainers.

ref: INSTA-8157

@aryamohanan aryamohanan changed the title fix: deprecated q library fix: deprecated q Aug 21, 2024
@aryamohanan aryamohanan marked this pull request as ready for review August 22, 2024 08:24
@aryamohanan aryamohanan requested a review from a team as a code owner August 22, 2024 08:24
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always try to put a deprecation warning.

See e.g.

packages/core/src/tracing/instrumentation/protocols/httpClient.js

hook.onModuleLoad('request', logDeprecatedWarning);

How is q instrumented?

packages/core/src/tracing/index.js Outdated Show resolved Hide resolved
@aryamohanan
Copy link
Contributor Author

We always try to put a deprecation warning.

See e.g.

packages/core/src/tracing/instrumentation/protocols/httpClient.js

hook.onModuleLoad('request', logDeprecatedWarning);

How is q instrumented?

We don't have instrumentation for this and not creating spans for q.

@aryamohanan aryamohanan merged commit d86f939 into main Aug 22, 2024
1 check passed
@aryamohanan aryamohanan deleted the deprecate-q branch August 22, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants