Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avoided creating standalone exit spans when using the SDK #1234

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 changed the title fix: disallowed exit spans without entry spans using the SDK and loops fix(core): disallowed exit spans without entry spans using the SDK and loops Jul 11, 2024
@kirrg001 kirrg001 changed the title fix(core): disallowed exit spans without entry spans using the SDK and loops fix(core): avoided creating standalone exit spans when using the SDK Jul 18, 2024
@kirrg001 kirrg001 force-pushed the fix-reduced-span-problem branch from 872326d to 33dd5cc Compare July 18, 2024 11:01
@kirrg001 kirrg001 marked this pull request as ready for review July 18, 2024 11:24
@kirrg001 kirrg001 requested a review from a team as a code owner July 18, 2024 11:24
@kirrg001
Copy link
Contributor Author

This is not an easy fix. I hope it won't break other SDK use cases 🤞

@aryamohanan
Copy link
Contributor

LGTM

@kirrg001 kirrg001 force-pushed the fix-reduced-span-problem branch from 331ec8a to b25792d Compare July 22, 2024 07:47
@kirrg001 kirrg001 merged commit 9a0d8fc into main Jul 22, 2024
1 check passed
@kirrg001 kirrg001 deleted the fix-reduced-span-problem branch July 22, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants