feat: added support for mssql v11 #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
build-fix-mssql
branch
from
e5fd8e9 to
30c3b39
Compare
aryamohanan
changed the title
kirrg001
reviewed
Jun 20, 2024
| if (mssqlVersion === 'latest') { | ||
| mochaSuiteFn = semver.lt(process.versions.node, '18.0.0') ? describe.skip : mochaSuiteFn; | ||
| } | ||
| // mssql dropped support for Node.js v14 and below. |
kirrg001
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-8736
The
mssqlpackage dropped support for Node v14 in version 10. See mssql v10 release notes. Our tests were mistakenly using version 9 ofmssqldue to issues with TypeORM, and this error was not identified earlier. The problem was resolved in this commit, which brought the issue to light. As a result, we have skipped Node v14 tests formssqlversion 10. Additionally,mssqlversion 11 has dropped support for Node.js 16.