feat(couchbase): added support for raw sql queries #1187
Merged
+138
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
changed the title
kirrg001
commented
Jun 20, 2024
| @@ -393,15 +393,15 @@ mochaSuiteFn('tracing/couchbase', function () { | |||
| ); | |||
| })); | |||
|
|
|||
| // flaky on CI | |||
| it.skip('[analyticsindexes] must trace', () => | |||
| it('[analyticsindexes] must trace', () => | |||
There was a problem hiding this comment.
FYI un-skipped for now. I want to see if they are still flaky.
kirrg001
commented
Jun 20, 2024
| }) | ||
| ); | ||
| } | ||
| }) | ||
| ); | ||
| })); | ||
|
|
||
| // flaky on CI | ||
| it.skip('[searchquery] must trace', () => | ||
| it('[searchquery] must trace', () => |
There was a problem hiding this comment.
FYI un-skipped for now. I want to see if they are still flaky.
aryamohanan
approved these changes
Jun 21, 2024
refs https://jsw.ibm.com/browse/INSTA-5903 - extract full query for cluster.query & scope.query - for all other ORM operations we cannot extract the raw sql queries, because the core library is written in c++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-5903