feat(collector): added support for @elastic/elasticsearch v8 #707
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
kirrg001
changed the title
kirrg001
force-pushed
the
dependabot/npm_and_yarn/main/elastic/elasticsearch-8.6.0
branch
from
aeffbd7 to
a880e07
Compare
| // eslint-disable-next-line no-useless-concat | ||
| `@elastic/elasticsearch@${version}/` + `instrumentation flavor: ${instrumentationFlavor}`, | ||
| function () { | ||
| const indiceKey = version === 'latest' ? 'Indices.refresh' : 'indices.refresh'; |
There was a problem hiding this comment.
teeny tiny typo nitpick: is that meant to read indicesKey? Or indexKey?
| const parsedConnectionUrl = new URL(connectionString); | ||
| span.data.elasticsearch.address = parsedConnectionUrl.hostname; | ||
| span.data.elasticsearch.port = parsedConnectionUrl.port; |
There was a problem hiding this comment.
suggestion: We could potentially shave off some CPU cycles by moving the new URL(...) into the monkey-patched es.Client = function InstanaClient() { function I think. If I am not mistaken, the way it is implemented now, we parse the URL on every request, although it is always the same connectionString value.
OTOH, users might instantiate multiple instances of es.Client, talking to different ElasticSearch clusters/servers, I guess? Could keeping only one connectionString might lead to scenarios where we record the wrong target address/port for some calls?
There was a problem hiding this comment.
I will put the URL parsing to the patched client override for now.
OTOH, users might instantiate multiple instances of es.Client
Yes totally true. But I think there are a lot of instrumentations which ignore this use case and store data in global variables inside the instrumentations. I'd like to ignore this case.
Bumps [@elastic/elasticsearch](https://github.com/elastic/elasticsearch-js) from 7.17.0 to 8.6.0. - [Release notes](https://github.com/elastic/elasticsearch-js/releases) - [Changelog](https://github.com/elastic/elasticsearch-js/blob/main/docs/changelog.asciidoc) - [Commits](elastic/elasticsearch-js@v7.17.0...v8.6.0) --- updated-dependencies: - dependency-name: "@elastic/elasticsearch" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
kirrg001
force-pushed
the
dependabot/npm_and_yarn/main/elastic/elasticsearch-8.6.0
branch
from
3f37db1 to
5d255b6
Compare
kirrg001
deleted the
dependabot/npm_and_yarn/main/elastic/elasticsearch-8.6.0
branch
Bumps @elastic/elasticsearch from 7.17.0 to 8.6.0.
Release notes
Sourced from
@elastic/elasticsearch's releases.Changelog
Sourced from
@elastic/elasticsearch's changelog.... (truncated)
Commits
281ac00[8.6] Add release notes for 8.6.00f0c600[8.6] Bump@elastic/transportto 8.3.138e4b23Add a changelog for 8.5.004634afUpdate all docs refs to 'current' instead of 'master'f79f4e8Remove unnecessary ts-expect-error560dfd3Fix docs URLs to use 'current' instead of 'master'ebbc296Bumps to version 8.6.0 (#1762)6ccdab5Add changelog for 8.4.08f9ed67Update APIs to 8.5.0-SNAPSHOT4ebffbcBumps to version 8.5.0Maintainer changes
This version was pushed to npm by sethmlarson, a new releaser for
@elastic/elasticsearchsince your current version.You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)