chore: optimise url parsing

instana · Feb 24, 2023 · 3f37db1 · 3f37db1
1 parent 9f06fa2
commit 3f37db1
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/packages/core/src/tracing/instrumentation/database/elasticsearchModern.js b/packages/core/src/tracing/instrumentation/database/elasticsearchModern.js
@@ -30,7 +30,7 @@ exports.init = function init() {
   requireHook.onModuleLoad('@elastic/elasticsearch', instrument);
 };
 
-let connectionString;
+let parsedConnectionUrl;
 
 function instrument(es, esModuleFilename) {
   // v8
@@ -40,7 +40,12 @@ function instrument(es, esModuleFilename) {
       const client = new OriginalClient(...arguments);
 
       if (client.connectionPool && client.connectionPool.connections && client.connectionPool.connections.length > 0) {
-        connectionString = client.connectionPool.connections[0].url;
+        const connectionString = client.connectionPool.connections[0].url;
+        try {
+          parsedConnectionUrl = new URL(connectionString);
+        } catch (parseErrr) {
+          /* ignore */
+        }
       }
 
       return client;
@@ -215,8 +220,7 @@ function parseConnectionFromResult(span, result) {
       span.data.elasticsearch.address = connectionUrl.hostname;
       span.data.elasticsearch.port = connectionUrl.port;
     }
-  } else if (connectionString) {
-    const parsedConnectionUrl = new URL(connectionString);
+  } else if (parsedConnectionUrl) {
     span.data.elasticsearch.address = parsedConnectionUrl.hostname;
     span.data.elasticsearch.port = parsedConnectionUrl.port;
   }