fix: dropped support for q library #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
reviewed
Oct 11, 2024
kirrg001
approved these changes
Oct 14, 2024
aryamohanan
force-pushed
the
v4
branch
2 times, most recently
from
a959535 to
5c46aec
Compare
aryamohanan
added a commit
that referenced
this pull request
Oct 18, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 21, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 22, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Q library has been officially deprecated. Last release was 7 years ago.
The maintainers announced this deprecation in the project's GitHub repository, advising developers to transition to native JavaScript promises. The Q library, an early tool for handling promises in JavaScript, is no longer needed because modern JavaScript now includes built-in support for promises.
We already deprecated the library in v3, see #1282. So removing the support in V4.
Note: We don't have instrumentation for this and not creating spans for q.
Commit as a breaking change.