fix(kafka): enforced 'string' format for Kafka trace headers and removed 'binary' support #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
kafka-migration
branch
from
b7a1ec7 to
ee2c2dd
Compare
aryamohanan
force-pushed
the
kafka-migration
branch
from
ee2c2dd to
9f93755
Compare
aryamohanan
force-pushed
the
kafka-migration
branch
from
9f93755 to
f6a500c
Compare
aryamohanan
changed the title
kirrg001
reviewed
Sep 9, 2024
| @@ -364,9 +361,7 @@ mochaSuiteFn('tracing/messaging/node-rdkafka', function () { | |||
| let consumerControls; | |||
There was a problem hiding this comment.
Putting it here:
Do we still need this comment:
https://github.com/instana/nodejs/pull/1296/files#diff-1b77510f78eb55910153dd198bee01c7d0e63aa32d30da88adae14562db0d5f8R13
There was a problem hiding this comment.
IMO, the warning and debug log are related to the Kafka header format configuration option. Since the logWarningForKafkaHeaderFormat method has been removed from this PR, these comments are no longer necessary in the tests.
|
How about we separate the tasks in https://jsw.ibm.com/browse/INSTA-786?
|
aryamohanan
force-pushed
the
kafka-migration
branch
from
dda3908 to
4aad293
Compare
kirrg001
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
LGTM ♡
Commit message issue:
Please add "BREAKING CHANGE" in the commit body.
See convention.
IMO this is not a feature. Its a fix.
fix(kafka): removed binary trace header support
refs XBREAKING CHANGE
|
@aryamohanan Please change the target branch to v4! |
|
Wrong PR ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ |
aryamohanan
force-pushed
the
kafka-migration
branch
from
4aad293 to
8f7a4fd
Compare
aryamohanan
changed the title
aryamohanan
added a commit
that referenced
this pull request
Sep 11, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Sep 25, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Sep 30, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
abhilash-sivan
pushed a commit
that referenced
this pull request
Sep 30, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 7, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 18, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 21, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 22, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
aryamohanan
added a commit
that referenced
this pull request
Oct 23, 2024
…d binary support (#1296) BREAKING CHANGE: - Removed the ability to configure the header format; headers will always be sent in 'string' format. - Removed support for 'binary' format and code related to sending headers in 'binary' or 'both' formats. refs INSTA-809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka header migration phase-2
Always send Kafka trace correlation headers in format 'string'
Remove the ability to configure the header format
Remove the code associated with sending headers in format 'binary' or sending 'both' formats.
Tasks
Post Release
refs https://jsw.ibm.com/browse/INSTA-809
This PR should merge against V4 branch.