Skip to content

Commit

Permalink
test: removed the references of header-format
Browse files Browse the repository at this point in the history
  • Loading branch information
aryamohanan committed Sep 9, 2024
1 parent 71d0276 commit 4aad293
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion packages/collector/src/announceCycle/unannounced.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ const maxRetryDelay = 60 * 1000; // one minute
/**
* @typedef {Object} KafkaTracingConfig
* @property {boolean} [trace-correlation]
* @property {string} [header-format]
*/

module.exports = {
Expand Down
3 changes: 1 addition & 2 deletions packages/collector/test/announceCycle/unannounced_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,7 @@ describe('unannounced state', () => {
prepareAnnounceResponse({
tracing: {
kafka: {
'trace-correlation': false,
'header-format': 'string'
'trace-correlation': false
}
}
});
Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/tracing/cls.js
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,7 @@ function startSpan(spanName, kind, traceId, parentSpanId, w3cTraceContext) {

// If the client code has specified a trace ID/parent ID, use the provided IDs.
if (traceId) {
// The incoming trace ID/span ID from an upstream tracer could be shorter than the standard length. Some of our code
// (in particular, the binary Kafka trace correlation header X_INSTANA_C) assumes the standard length. We normalize
// The incoming trace ID/span ID from an upstream tracer could be shorter than the standard length. We normalize
// both IDs here by left-padding with 0 characters.

// Maintenance note (128-bit-trace-ids): When we switch to 128 bit trace IDs, we need to left-pad the trace ID to 32
Expand Down

0 comments on commit 4aad293

Please sign in to comment.