Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import protocol from typing extensions to ensure Python 3.7 compatibility #59

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix: import protocol from typing extensions to ensure Python 3.7 compatibility #59

merged 1 commit into from
Nov 18, 2022

Conversation

dluo96
Copy link
Contributor

@dluo96 dluo96 commented Nov 18, 2022

Closes #55.

Imported Protocol from typing_extensions instead of typing to ensure Python 3.7 compatibility.

@dluo96 dluo96 self-assigned this Nov 18, 2022
@clement-bonnet clement-bonnet added the bug Something isn't working label Nov 18, 2022
@dluo96 dluo96 merged commit 4beae2e into instadeepai:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clement-bonnet clement-bonnet clement-bonnet approved these changes

Assignees

@dluo96 dluo96

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: protocol not supported in Python 3.7
2 participants
@dluo96 @clement-bonnet