Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requirements #224

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

sash-a
Copy link
Collaborator

@sash-a sash-a commented Feb 14, 2024

Sokoban introduced huggingface-hub as a requirement. It's only in requirements-train, but it's need to run jumanji, so moving it to the main requirements

@sash-a sash-a self-assigned this Feb 14, 2024
@clement-bonnet
Copy link
Collaborator

Good spot! LGTM, will look into why tests are failing.

@clement-bonnet
Copy link
Collaborator

CI should be fixed after merging #225

Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clement-bonnet clement-bonnet merged commit ed9a355 into instadeepai:main Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants