Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/type hints #215

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Conversation

dantp-ai
Copy link
Contributor

@dantp-ai dantp-ai commented Jan 6, 2024

This PR solves #95

Development environment

3.8.10 (default, Jan  5 2024, 09:18:58)
[Clang 15.0.0 (clang-1500.1.0.2.5)] darwin

  • Ran mypy
  • Ran tests
  • Ran pre-commit

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2024

CLA assistant check
All committers have signed the CLA.

@dantp-ai
Copy link
Contributor Author

dantp-ai commented Jan 6, 2024

I developed and tested successfully on Python 3.8.10.

Upon opening this PR, the tests seem to have failed for Python 3.9. When running mypy it finds 25 errors in 20 files (checked 297 source files).

So, I ran mypy also on the latest commit that is not part of this PR (to check whether I introduced these issues), and the same number of errors were found. Can it be that the source code on main has not yet been tested for Python 3.9?

If so, I think it's best to resolve these 25 issues in a different PR and block the current PR until the other one has successfully been merged. Thoughts?

@sash-a
Copy link
Collaborator

sash-a commented Jan 9, 2024

I'll have a look into the mypy issue 😄

Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 😄

@dantp-ai
Copy link
Contributor Author

My pleasure. I thought it's a good first issue.

I see that you opened PR #216. Once that is approved, hopefully the linting is gonna pass here too and we can merge.

Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the improvement!

@sash-a sash-a merged commit f58c71c into instadeepai:main Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants