Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tetris): implement Tetris environment #132

Merged
merged 77 commits into from
Jun 3, 2023

Conversation

MedAliMimouni
Copy link
Contributor

This PR contains the implementation of the Tetris environment.
It contains the env implementations, the tests the rendering, except for the A2C networks.

@CLAassistant
Copy link

CLAassistant commented May 9, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ MedAliMimouni
✅ clement-bonnet
❌ med


med seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@clement-bonnet clement-bonnet changed the title Feat (Tetris) Implement environment feat(Tetris): implement Tetris environment May 9, 2023
@clement-bonnet clement-bonnet changed the title feat(Tetris): implement Tetris environment feat(tetris): implement Tetris environment May 9, 2023
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution. The environment looks very cool. I have left a few comments to improve the code. Please let me know if you have any questions.

README.md Outdated Show resolved Hide resolved
docs/environments/tetris.md Outdated Show resolved Hide resolved
docs/environments/tetris.md Outdated Show resolved Hide resolved
docs/environments/tetris.md Outdated Show resolved Hide resolved
docs/environments/tetris.md Show resolved Hide resolved
jumanji/environments/packing/tetris/utils.py Outdated Show resolved Hide resolved
jumanji/environments/packing/tetris/utils.py Outdated Show resolved Hide resolved
jumanji/training/networks/tetris/actor_critic.py Outdated Show resolved Hide resolved
jumanji/training/networks/tetris/actor_critic.py Outdated Show resolved Hide resolved
jumanji/training/setup_train.py Outdated Show resolved Hide resolved
MedAliMimouni and others added 18 commits May 12, 2023 09:47
Co-authored-by: Clément Bonnet <[email protected]>
jumanji/__init__.py Outdated Show resolved Hide resolved
clement-bonnet
clement-bonnet previously approved these changes Jun 1, 2023
docs/env_anim/tetris.gif Outdated Show resolved Hide resolved
clement-bonnet
clement-bonnet previously approved these changes Jun 2, 2023
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clement-bonnet
clement-bonnet previously approved these changes Jun 2, 2023
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clement-bonnet
clement-bonnet previously approved these changes Jun 3, 2023
@clement-bonnet clement-bonnet enabled auto-merge (squash) June 3, 2023 17:19
@clement-bonnet clement-bonnet merged commit 6f7df7f into instadeepai:main Jun 3, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants