-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tetris): implement Tetris environment #132
Conversation
med seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution. The environment looks very cool. I have left a few comments to improve the code. Please let me know if you have any questions.
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
Co-authored-by: Clément Bonnet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the implementation of the Tetris environment.
It contains the env implementations, the tests the rendering, except for the A2C networks.