Skip to content
This repository was archived by the owner on Mar 16, 2022. It is now read-only.

type(pd.NaT) instead of pd._libs.tslib.NaTType#33

Closed
mathieuripert wants to merge 3 commits intomasterfrom
pandas-tslib-nattype-deprecated
Closed

type(pd.NaT) instead of pd._libs.tslib.NaTType#33
mathieuripert wants to merge 3 commits intomasterfrom
pandas-tslib-nattype-deprecated

Conversation

@mathieuripert
Copy link
Contributor

The type import pandas.tslib.NaTType is deprecated and can be replaced by using type(pandas.NaT) (GH16146)

It is breaking when using jardin with latest pandas 0.23.

from https://pandas-docs.github.io/pandas-docs-travis/whatsnew.html
pandas-dev/pandas#16146

@neutralino1
Copy link
Contributor

Nice, can you look at the build failure? It looks related to the new pandas version though.

@mathieuripert
Copy link
Contributor Author

fixed the issue with newest pandas and freezegun. but i get another error!
same with #34

@mathieuripert
Copy link
Contributor Author

closing this PR.
See PR #35

ganesh-krishnan added a commit that referenced this pull request Jun 13, 2019
reference issue #33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants