Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] use Mint to manage SwiftLint #52

Merged
merged 7 commits into from
Feb 22, 2020
Merged

Conversation

ngoleo
Copy link
Contributor

@ngoleo ngoleo commented Feb 21, 2020

What

  • Use Mint to install swiftlint so that we don't have a tooling dependency in Package.swift. This will let us configure Nantes for SPM support.

@ngoleo ngoleo changed the title [tools] use Mint to install and upgrade SwiftLint to 0.39.1 [tools] use Mint to install SwiftLint Feb 22, 2020
@ngoleo ngoleo changed the title [tools] use Mint to install SwiftLint [tools] use Mint to manage SwiftLint Feb 22, 2020
@ngoleo ngoleo merged commit e4d0070 into master Feb 22, 2020
@ngoleo ngoleo mentioned this pull request Feb 22, 2020
@Kaspik
Copy link

Kaspik commented Mar 26, 2020

@ngocholo Hey! Could you please release current master as a new version so SPM works without Swiftlint for everyone? Latest release from October is still not working.

Also, it might be necessary to first merge https://github.com/instacart/Nantes/pull/54/files ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants