Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.markdown #107

Closed
wants to merge 2 commits into from
Closed

Update readme.markdown #107

wants to merge 2 commits into from

Conversation

davidkhala
Copy link

Fix the broken badge.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48d3bb5) 98.30% compared to head (ad670ac) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files           2        2           
  Lines         236      236           
  Branches       99       99           
=======================================
  Hits          232      232           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t fix anything, it just removes it, which isn’t acceptable.

The fix would be to change the version badge URL to https://versionbadg.es/inspect-js/node-deep-equal.svg


Node's `assert.deepEqual() algorithm` as a standalone module, that also works in browser environments.

It mirrors the robustness of node's own `assert.deepEqual` and is robust against later builtin modification.

[![github actions][actions-image]][actions-url]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this badge works fine.

@ljharb ljharb marked this pull request as draft January 25, 2024 15:07
@davidkhala davidkhala closed this Apr 17, 2024
@davidkhala davidkhala deleted the patch-1 branch April 17, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants