Check function lengths as well for equality.

inspect-js · Jan 14, 2014 · e944591 · e944591
1 parent 0169b55
commit e944591
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -54,7 +54,10 @@ module.exports = function isEqual(value, other) {
 	}
 
 	if (type === funcType) {
-		return isEqual(value.name, other.name) && isEqual(String(value), String(other));
+		if (!isEqual(value.name, other.name)) { return false; }
+		if (!isEqual(value.length, other.length)) { return false; }
+
+		return isEqual(String(value), String(other));
 	}
 
 	if (type === objType) {

diff --git a/test.js b/test.js
@@ -98,8 +98,11 @@ test('functions', function (t) {
 	var anon1 = function () { /* ANONYMOUS! */ };
 	var anon2 = function () { /* ANONYMOUS! */ };
 
+	var anon1withArg = function (a) { /* ANONYMOUS! */ };
+
 	t.ok(isEqual(f1, f1), 'same function is equal to itself');
 	t.ok(isEqual(anon1, anon1), 'same anon function is equal to itself');
+	t.notOk(isEqual(anon1, anon1withArg), 'similar anon function with different lengths are not equal');
 
 	t.notOk(isEqual(f1, g), 'functions with different names but same implementations are not equal');
 	t.ok(isEqual(f1, f2), 'functions with same names but same implementations are equal');