Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide additional gemspecs for various backends and a 'core' that they all depend on. #291

Closed
wants to merge 4 commits into from

Conversation

miah
Copy link
Contributor

@miah miah commented Apr 27, 2018

This adds a few gem specs to allow Train to be distributed without support for additional cloud providers. I've left the train.gemspec alone so train can still be distributed as is. In the future after these supplemental gem specs have proven themselves train.gemspec would be modified to depend on them.

We now have:

  • train-core which is just Train, with WinRM, SSH, and Docker support.
  • train-aws which provides AWS support.
  • train-azure which provides Azure support.
  • train-gcp which provides Google Cloud Provider support.

The aws, azure, and gcp gems all depend on core. So if you want to install Train with support for AWS you can install train-aws and you'll be fine.

The description and summary of our gem specs could probably be improved here (HELP)

These supplemental gem specs do not include distribution of tests (spec.test_files) as that was deprecated.

@miah miah requested a review from a team April 27, 2018 19:38
@miah miah force-pushed the miah/train_core branch from 1366132 to 3e17df5 Compare April 27, 2018 22:31
@miah miah closed this Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants