CHEF-12175: Remove use of Kernel.open or IO.read or similar sinks with a non-constant value
#7079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sonu Saha <[email protected]>
…al files Signed-off-by: Sonu Saha <[email protected]>
Signed-off-by: Sonu Saha <[email protected]>
✅ Deploy Preview for chef-inspec canceled.
|
Signed-off-by: Sonu Saha <[email protected]>
Signed-off-by: Sonu Saha <[email protected]>
Signed-off-by: Sonu Saha <[email protected]>
Vasu1105
approved these changes
Jul 4, 2024
Nik08
approved these changes
Jul 10, 2024
aaronlippold
pushed a commit
to mitre/inspec
that referenced
this pull request
Jul 10, 2024
… with a non-constant value (inspec#7079) * fix: update io reads to fix codescanning vuln Signed-off-by: Sonu Saha <[email protected]> * fix: remove kernel#open fallback and update open method to handle local files Signed-off-by: Sonu Saha <[email protected]> * fix: replace io.readlines to file.readlines Signed-off-by: Sonu Saha <[email protected]> * chore: fix lint offense, unnecessary space Signed-off-by: Sonu Saha <[email protected]> * fix: raise exception for standard errors as FetcherFailure Signed-off-by: Sonu Saha <[email protected]> * chore: update exception message Signed-off-by: Sonu Saha <[email protected]> --------- Signed-off-by: Sonu Saha <[email protected]>
Vasu1105
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ig file in use. (#7070) * modify resource * windows compatibility * end line * removing comments to clean things up Signed-off-by: Aaron Lippold <[email protected]> * CHEF-12175: Remove use of `Kernel.open` or `IO.read` or similar sinks with a non-constant value (#7079) * fix: update io reads to fix codescanning vuln Signed-off-by: Sonu Saha <[email protected]> * fix: remove kernel#open fallback and update open method to handle local files Signed-off-by: Sonu Saha <[email protected]> * fix: replace io.readlines to file.readlines Signed-off-by: Sonu Saha <[email protected]> * chore: fix lint offense, unnecessary space Signed-off-by: Sonu Saha <[email protected]> * fix: raise exception for standard errors as FetcherFailure Signed-off-by: Sonu Saha <[email protected]> * chore: update exception message Signed-off-by: Sonu Saha <[email protected]> --------- Signed-off-by: Sonu Saha <[email protected]> * fix: Missing regular expression anchor (#7077) Signed-off-by: Sonu Saha <[email protected]> * Bump version to 6.6.27 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * Fix gitignore file in docs dir (#7082) Signed-off-by: Ian Maddaus <[email protected]> * Bump version to 6.6.28 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * adding docs now that the gitignore is fixed. Signed-off-by: Aaron Lippold <[email protected]> * add docs for sshd_active_config resource * fix docs * unit tests * rubocop on ssh_config.rb, sshd_con_test.rb, and sshd_active_config.md * rename active path in method * doc fix * Linting Corrections for Active SSHD Config (#1) Signed-off-by: Clinton Wolfe <[email protected]> * Update sshd_active_config.md updated version * doc version update --------- Signed-off-by: Aaron Lippold <[email protected]> Signed-off-by: Sonu Saha <[email protected]> Signed-off-by: Ian Maddaus <[email protected]> Signed-off-by: Clinton Wolfe <[email protected]> Co-authored-by: Daniel Medina <[email protected]> Co-authored-by: Sonu Saha <[email protected]> Co-authored-by: Chef Expeditor <[email protected]> Co-authored-by: Ian Maddaus <[email protected]> Co-authored-by: Clinton Wolfe <[email protected]>
Nik08
pushed a commit
that referenced
this pull request
Jul 29, 2024
… with a non-constant value (#7079) * fix: update io reads to fix codescanning vuln Signed-off-by: Sonu Saha <[email protected]> * fix: remove kernel#open fallback and update open method to handle local files Signed-off-by: Sonu Saha <[email protected]> * fix: replace io.readlines to file.readlines Signed-off-by: Sonu Saha <[email protected]> * chore: fix lint offense, unnecessary space Signed-off-by: Sonu Saha <[email protected]> * fix: raise exception for standard errors as FetcherFailure Signed-off-by: Sonu Saha <[email protected]> * chore: update exception message Signed-off-by: Sonu Saha <[email protected]> --------- Signed-off-by: Sonu Saha <[email protected]>
4 tasks
Nik08
added a commit
that referenced
this pull request
Jul 29, 2024
… with a non-constant value (#7079) (#7112) * fix: update io reads to fix codescanning vuln * fix: remove kernel#open fallback and update open method to handle local files * fix: replace io.readlines to file.readlines * chore: fix lint offense, unnecessary space * fix: raise exception for standard errors as FetcherFailure * chore: update exception message --------- Signed-off-by: Sonu Saha <[email protected]> Co-authored-by: Sonu Saha <[email protected]>
Nik08
pushed a commit
that referenced
this pull request
Sep 13, 2024
… with a non-constant value (#7079) * fix: update io reads to fix codescanning vuln Signed-off-by: Sonu Saha <[email protected]> * fix: remove kernel#open fallback and update open method to handle local files Signed-off-by: Sonu Saha <[email protected]> * fix: replace io.readlines to file.readlines Signed-off-by: Sonu Saha <[email protected]> * chore: fix lint offense, unnecessary space Signed-off-by: Sonu Saha <[email protected]> * fix: raise exception for standard errors as FetcherFailure Signed-off-by: Sonu Saha <[email protected]> * chore: update exception message Signed-off-by: Sonu Saha <[email protected]> --------- Signed-off-by: Sonu Saha <[email protected]>
Nik08
pushed a commit
that referenced
this pull request
Sep 13, 2024
…ig file in use. (#7070) * modify resource * windows compatibility * end line * removing comments to clean things up Signed-off-by: Aaron Lippold <[email protected]> * CHEF-12175: Remove use of `Kernel.open` or `IO.read` or similar sinks with a non-constant value (#7079) * fix: update io reads to fix codescanning vuln Signed-off-by: Sonu Saha <[email protected]> * fix: remove kernel#open fallback and update open method to handle local files Signed-off-by: Sonu Saha <[email protected]> * fix: replace io.readlines to file.readlines Signed-off-by: Sonu Saha <[email protected]> * chore: fix lint offense, unnecessary space Signed-off-by: Sonu Saha <[email protected]> * fix: raise exception for standard errors as FetcherFailure Signed-off-by: Sonu Saha <[email protected]> * chore: update exception message Signed-off-by: Sonu Saha <[email protected]> --------- Signed-off-by: Sonu Saha <[email protected]> * fix: Missing regular expression anchor (#7077) Signed-off-by: Sonu Saha <[email protected]> * Bump version to 6.6.27 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * Fix gitignore file in docs dir (#7082) Signed-off-by: Ian Maddaus <[email protected]> * Bump version to 6.6.28 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * adding docs now that the gitignore is fixed. Signed-off-by: Aaron Lippold <[email protected]> * add docs for sshd_active_config resource * fix docs * unit tests * rubocop on ssh_config.rb, sshd_con_test.rb, and sshd_active_config.md * rename active path in method * doc fix * Linting Corrections for Active SSHD Config (#1) Signed-off-by: Clinton Wolfe <[email protected]> * Update sshd_active_config.md updated version * doc version update --------- Signed-off-by: Aaron Lippold <[email protected]> Signed-off-by: Sonu Saha <[email protected]> Signed-off-by: Ian Maddaus <[email protected]> Signed-off-by: Clinton Wolfe <[email protected]> Co-authored-by: Daniel Medina <[email protected]> Co-authored-by: Sonu Saha <[email protected]> Co-authored-by: Chef Expeditor <[email protected]> Co-authored-by: Ian Maddaus <[email protected]> Co-authored-by: Clinton Wolfe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
Related Issue
Types of changes
Checklist: