[ WIP ] Attempted upgrade to yew 0.20 for mipsy-web, Run does not work #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpanishPear
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My (very long) attempt at upgrading mipsy-web to yew v0.20.
This upgrade works for yew 0.20 and yew-agent v0.2 , but the
runbehaviour will not work.This is because the pattern we based the worker on is fundamentally opposed to the behaviour of yew-agent v2, so will require lots of rewriting. We could attempt to hack our way into it working in yew 0.20 but I don't see the benefit, and will abandon this until yewstack/yew#2773 has been merged, during which I'll redesign the worker methodology.
For more discussion on the patterns, checkout https://discord.com/channels/701068342760570933/1149300253820997653/1149300253820997653 in the yew discord
Most things work as is! Except the run button, as the automatic client -> worker -> client communication does not work without self-referencing data-structures.