-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 support #9
Conversation
I must think how to deal with Vue2 projects that use this library. Any thoughts? |
I think we can do something like what https://github.com/Norserium/vue-advanced-cropper is doing, they have a I don't know how this tagging and releasing works in the npmjs registry, but does this sound like a good idea to you? |
Any update on this? :) |
O, so sorry. I need more time. Right now my country defending russian invasion, so I'm a little busy now. Hope in few days I'll return to your problem. |
This PR is currently trending on HN. @insky you may want to limit it to contributors to prevent spam. Locking may limit emoji reaction though :/ (which will block people who wants to show their support) This is considered a good common practice but in this context I guess letting people show their love cannot really be seen as "spam". Good luck 🇺🇦 |
I think that would be a good decision, trending issues tend to invite comments which eventually become a moderation burden. |
Good luck @insky ❤️ |
War makes everything else quickly seem insignificant. God be with you @insky, may you return home safely and victorious. |
Long live Ukraine! |
@insky: I don't need your PRs, I need ammo |
given that programmers are from everywhere now, and the vast majority of us are anti-war, I wonder what glories might happen if we combined forces... Good luck @insky , Putin's going to suffer for this. Unfortunately, this is now going to dominate this PR thanks to HN. Please don't lock |
@MaKiPL people find very different ways to cope with the situation. Laugh is definitely one of the most accessible means to cope. |
Hey, good luck with defending your Country ❤️ |
Genuinely hope you're okay brother! Godspeed! |
Let me express my admiration to brave people of Ukraine. I wish you victory. Kazakh people really understand the evil your are fighting with. |
✅ This branch has no conflicts with the base branchLet’s make it that way IRL |
Russia thought they could just rebase and be done with it. They didn't count on so many merge conflicts. Stay safe my friend. |
Героям слава! |
slava ukraine! |
It is unfortunate. Glory to ukraine!!! <3 ukraine |
I wish you and your country nothing but safety and prosperity ❤️ |
🇺🇦 |
Thank you, guys. Can I ask for your help? Russian fake sites must be DDOS-ed. |
Good luck @insky 🇺🇦 |
Don't worry, Putin's TTL is getting shorter each day. 😂 |
You're a legend, @insky!! Слава Україні! 🇺🇦 |
@insky Slava Ukraini. I wish you and your family well and hope you and your country make it out of this Russian aggression somehow. But it might be time to close down this PR, wish I could continue to get updates from you, but it's clearily being brigadier by russian trolls trying to spread misinformation. |
Really hope you and your family are safe. Good luck Ukraine ! 🇺🇦 |
Today is 12th day of war. Ukrainian army successfully restrains occupants, Glory to the Heroes! Glory to Ukraine! 🇺🇦 |
@UmbReTHY Surely, 900 Azov members IN TOTAL and the "mere threat" of joining NATO justifies the warring against an entire peaceful European democracy and the slaughtering and terrorizing of innocents by an ex-Stasi/KGB asshole, right? GTFO. Our first mistake was doing business with communists and thus enriching their non-democratically-elected leaders. As soon as Ukraine joins NATO, Russia can go EABOD.
You mean the absolutely ridiculous difference between the official Russian COVID death toll and the best estimate according to excess deaths? That fraud? https://imgur.com/a/eDw8WaK taken from https://www.economist.com/graphic-detail/coronavirus-excess-deaths-estimates (Sidenote, the actual worldwide number is probably at least 20 million deaths) May this latest nightmare end soon. |
Слава Украине |
Hi, guys. I’m really don’t want to moderate this thread, but in future all anti-Ukrainian lunges will be removed. à la guerre comme à la guerre. Today I’ve planned my tomorrow route and settled refugee family. They fleed from Zaporizhzhia region and told me horrible things. Glory to Ukraine! 🇺🇦 |
@insky godspeed to you and yours! |
My plans destroyed again by circumstances, it has become a habit. Oh, yea, I’ve didn’t told you yet, I’m playing bass in two metal bands 😁 Glory to Ukraine! 🇺🇦 |
🤘 Dawn Of Victory 🤘 |
@insky what are your metal bands called? have they got any stuff online? best wishes and Slava Ukraine! 🫂 |
“Pomsta” and “Exact Division” |
Yesterday we moved to Ivano-Frankivsk, my former classmate give us a shelter. At the early morning russian missiles strikes an airports of Ivano-Frankivsk, Lutsk and Dniper. This monsters fires civilians. I have no words to describe what I feel. Glory to Ukraine! 🇺🇦 |
Yesterday evening we arrived in small town of Morshyn famous of its mineral water. We’ll stay here for a long time (if our luck doesn’t fail). Today my son played on the playground with other children for the first time in two weeks. I'm planning to return to work as soon as possible. Glory to Ukraine! 🇺🇦 |
Слава Украине товарищ |
Today 21st day of war, more than 100 children killed by russian soldiers, 21 hospitals and 2700 houses destroyed. More than 70% of russian people encourage war. Russia have no forgiveness. Glory to Ukraine! 🇺🇦 |
slava ukraine! |
Слава Україні! Chwała Ukrainie! 🇺🇦🇵🇱 |
any updates on your side @insky ? |
Hi, guys. We are still in Morshyn, every night and day here are multiple air raid alerts, fortunately without strikes. Some regions including Kyiv sufferers from massive missile and artillery attacks. Looks like russia wants to fight all civilized world. I’ve almost returned to my main job, our team is developing cross-chain DeFi application. It’s very hard to dive in work, there isn’t any table, nearby cafeterias are overcrowded and l must work on a chair or on a bed. Glory to Ukraine! 🇺🇦 |
Month ago the war has begun. Ukraine successfully defending against the world’s second strongest army. Our people are united as never before and victory will be ours at the cost of great grief. I’m going to visit a military office tomorrow and maybe join our army. I’m a reserve officer with no combat experience so I can be called to training center. I have no fear just a huge anger. Glory to Ukraine! 🇺🇦 |
and here I am writing fizzbuzzes... As a dev, I cant imagine having to join an army. Hope you are doing well. |
@insky good on you mate! As the russians are showing the world there's a lot of value in non combat roles, and the largest modern armies have something like 1:3 "tooth to tail". It looks like the Russians have the opposite. Please stay as safe as you can, and fight hard for you and yours. |
Hi, guys. Today I was at the military office third time and was postponed again. There are a lot of volunteers willing to join the army forces to defend Ukraine. Also, a lot of volunteers help supply military and medics, shelter and feed refugees, donate, etc. Russia shows all its monstrosity, deceit and lack of common sense. Glory to Ukraine! 🇺🇦 |
Best wishes and stay safe @insky! 🇺🇦 |
April 14, day 50 The whole world shuddered from the atrocities of the russians. They used chemical, shrapnel, ignition, and thermostatic bombs, shelling hospitals, schools, and residential buildings. They killed, tortured, and raped civilians, even children. Me and my family still in the town of Morshyn. I visited a military office again and again was postponed. Still attempting to return to a normal work schedule, but with no success. Glory to Ukraine! 🇺🇦 |
June 3, day 100 To recap, Russia have failed at almost any of the initial goals, has shown itself a nation of fascists, the world has identified the problem and has united to help Ukraine, albeit not without gas-chortling feet draggers, particularly within the EU. Ukrainians are incredibly brave and strong, and the Ukrainian military has suddenly shown itself as one of the world's most strongest even with very limited and outdated military technology. Couple days ago we've returned back home, to Kyiv. Very depressive to see destroyed and burned buildings, broken tanks, destroyed roads and bridges around the city. Standing in lines for gasoline and diesel can take up to several hours. But we at home and we are alive. Glory to Ukraine! 🇺🇦 |
Updated to Vue 3. |
Thank you Insky! Hang in there friend! |
It was pretty easy to port this library to Vue 3, I only had to change a few things:
value
tomodelValue
in the vue component (https://v3.vuejs.org/guide/migration/v-model.html#v-model)vue-color
package to use a Vue 3 fork (https://github.com/ckpack/vue-color)::v-deep
style selector (https://github.com/vuejs/rfcs/blob/master/active-rfcs/0023-scoped-styles-changes.md)I'm not sure what the best course of action is to create a new Vue 3 release for this package, since the current tag is
0.4.2
maybe we should bump that to1.0
when this gets merged?Fixes #8