Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React v15 production builds failing with npm3 because a broken version of babel-runtime gets installed into require() scope #101

Closed
insin opened this issue May 3, 2016 · 6 comments
Labels

Comments

@insin
Copy link
Owner

insin commented May 3, 2016

The Travis build for npm3 is currently failing because babel-runtime is now a transitive dependency of React v15 and npm3 moves it right up into require() scope, so the current approach of using Webpack's fallback config never gets a chance to fall back for projects which need optional: ['runtime'].

I filed a bug on Babel's issue tracker as every version of babel-runtime post 5.8.29 has a broken typeof-react-element.js module, which breaks nwb's production builds: https://phabricator.babeljs.io/T7288

@insin insin added the npm3 label May 3, 2016
@insin insin changed the title Tests failing in npm3 because of transitive dependencies in require() scope Tests failing in npm3 with React 15 because of transitive dependencies in require() scope May 7, 2016
@insin insin changed the title Tests failing in npm3 with React 15 because of transitive dependencies in require() scope Tests failing in npm3 with React 15 because a broken version of babel-runtime gets installed into require() scope May 7, 2016
@insin insin changed the title Tests failing in npm3 with React 15 because a broken version of babel-runtime gets installed into require() scope React v15 production builds failing with npm3 because a broken version of babel-runtime gets installed into require() scope May 7, 2016
@insin insin mentioned this issue May 7, 2016
@ghost
Copy link

ghost commented May 10, 2016

I installed npm install [email protected] to my project that is consuming nwb and it resolved it.
Can't we just increase the version in nwb ?

@insin
Copy link
Owner Author

insin commented May 10, 2016

I fixed this in the test async/await project by adding [email protected] to its dependencies - I'll add a note about this for npm3 users before releasing the next version.

@insin insin closed this as completed May 10, 2016
@ghost
Copy link

ghost commented May 10, 2016

Noticed that, but surprisingly I was experiencing the issue with v5.8.29, since nwb is using the same version. v5.8.38 (the latest by today) is ok.

@slmgc
Copy link

slmgc commented Jun 6, 2016

@insin I also experienced this issue with broken babel-runtime, installing v5.8.38 fixed it.

@insin
Copy link
Owner Author

insin commented Jun 6, 2016

Which version of React are you using? babel-runtime is no longer a transitive dependency as of unknown version of fbjs.

Installing any version of babel-runtime greater than the one nwb pins to should result in broken production builds in my experience - are you seeing that too?

@slmgc
Copy link

slmgc commented Jun 6, 2016

@insin [email protected]. Yeah, looks like you are right: [email protected] fixed the issue with development build, but broke the production build. Adding [email protected] to the project fixed the issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants