-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React v15 production builds failing with npm3 because a broken version of babel-runtime gets installed into require() scope #101
Comments
I installed |
I fixed this in the test |
Noticed that, but surprisingly I was experiencing the issue with v5.8.29, since |
@insin I also experienced this issue with broken babel-runtime, installing v5.8.38 fixed it. |
Which version of React are you using? Installing any version of |
@insin [email protected]. Yeah, looks like you are right: [email protected] fixed the issue with development build, but broke the production build. Adding [email protected] to the project fixed the issue, thanks! |
The Travis build for npm3 is currently failing because
babel-runtime
is now a transitive dependency of React v15 and npm3 moves it right up intorequire()
scope, so the current approach of using Webpack's fallback config never gets a chance to fall back for projects which needoptional: ['runtime']
.I filed a bug on Babel's issue tracker as every version of babel-runtime post 5.8.29 has a broken
typeof-react-element.js
module, which breaks nwb's production builds: https://phabricator.babeljs.io/T7288The text was updated successfully, but these errors were encountered: