Skip to content

Conversation

@shajoezhu
Copy link
Contributor

@shajoezhu shajoezhu commented Nov 24, 2025

fixing several min version of dependencies

Signed-off-by: Joe Zhu <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       262       5  98.09%   110, 216, 255, 523, 531
R/generics.R           125      12  90.40%   148, 286-290, 492, 504, 535, 565, 673, 686, 707-714
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        695      37  94.68%   134, 174, 405, 525-526, 618, 628-631, 649, 680, 770-771, 785-790, 820-823, 883-884, 973-974, 1001, 1029, 1081, 1243, 1279, 1336, 1384, 1387, 1391
R/mpf_exporters.R      287      28  90.24%   2, 102-112, 157, 193, 238, 241, 246, 426-432, 436, 439, 443, 491, 570
R/page_size.R           42       1  97.62%   219
R/pagination.R         771      56  92.74%   327-330, 435-450, 540, 595, 600, 641, 679-690, 766, 878-879, 901-910, 1051, 1054, 1276, 1313-1317, 1334-1342, 1423, 1563-1564, 1580-1581, 1595-1596
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 660-663, 669-673, 676-679, 686-691, 774-775, 915-916, 981-988, 1038-1042, 1111, 1164, 1183-1187, 1198, 1216, 1233, 1248, 1346, 1389, 1434, 1520, 1559, 1613, 1620
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 3040     218  92.83%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 194e794

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Unit Tests Summary

  1 files    8 suites   14s ⏱️
 56 tests  56 ✅ 0 💤 0 ❌
418 runs  418 ✅ 0 💤 0 ❌

Results for commit 194e794.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination 💚 $6.40$ $-1.03$ $0$ $0$ $0$ $0$

Results for commit ca632d2

♻️ This comment has been updated with latest results.

Updated knitr chunk options and added suggested dependent packages.

Signed-off-by: Joe Zhu <[email protected]>
Updated suggested_dependent_pkgs to use an empty vector.

Signed-off-by: Joe Zhu <[email protected]>
@shajoezhu shajoezhu enabled auto-merge (squash) November 24, 2025 06:26
test

Signed-off-by: Joe Zhu <[email protected]>
Updated package version requirements for knitr and rmarkdown.

Signed-off-by: Joe Zhu <[email protected]>
Removed unused chunk for suggested dependent packages and updated chunk options.

Signed-off-by: Joe Zhu <[email protected]>
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!! Thanks Joe

@shajoezhu shajoezhu merged commit 8fca1fb into main Nov 24, 2025
41 of 42 checks passed
@shajoezhu shajoezhu deleted the shajoezhu-patch-2 branch November 24, 2025 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants