Merge pull request #29 from kuhnroyal/feature/analyzer-report

feat (analyzer): allow reuse of an existing dartanalyzer report
insideapp-oss · Apr 26, 2021 · 698b1f7 · 698b1f7
2 parents 190d1b6 + 661dc46
commit 698b1f7
Show file tree

Hide file tree

Showing 5 changed files with 282 additions and 240 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 
 #### Enhancements
 
+- Allow re-using an existing dartanalyzer report with `sonar.dart.analysis.reportPath`
 - Add missing dart keywords `extension`, `on`, `mixin`
 
 #### Bug Fixes

diff --git a/dart-lang/src/main/java/fr/insideapp/sonarqube/dart/lang/DartSensor.java b/dart-lang/src/main/java/fr/insideapp/sonarqube/dart/lang/DartSensor.java
@@ -45,6 +45,7 @@ public class DartSensor implements Sensor {
     private static final Logger LOGGER = LoggerFactory.getLogger(DartSensor.class);
     private static final int EXECUTOR_TIMEOUT = 10000;
 	public static final String DART_ANALYSIS_USE_EXISTING_OPTIONS_KEY = "sonar.dart.analysis.useExistingOptions";
+	public static final String DART_ANALYSIS_USE_EXISTING_REPORT_PATH_KEY = "sonar.dart.analysis.reportPath";
 
     @Override
     public void describe(SensorDescriptor sensorDescriptor) {

diff --git a/dart-lang/src/main/java/fr/insideapp/sonarqube/dart/lang/SourceLinesProvider.java b/dart-lang/src/main/java/fr/insideapp/sonarqube/dart/lang/SourceLinesProvider.java
@@ -59,7 +59,7 @@ public SourceLine[] getLines(final InputStream inputStream, final Charset charse
             }
             sourceLines.add(new SourceLine(totalLines, count, global - count, global));
         } catch (final Throwable e) {
-            LOGGER.warn("Error occured reading file", e);
+            LOGGER.warn("Error occurred reading file", e);
         }
 
         return sourceLines.toArray(new SourceLine[0]);